[docs repo] fix can't edit a file, delete a file #10679
Closed
kongtiaowang wants to merge 54 commits into
Closed
Conversation
kongtiaowang
added
the
29.0.0 - Bugs
github-actions
Bot
added
Language: PHP
CamilleBeau
added
the
Critical to release
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lapadulamichael
added
the
Passed manual tests
lapadulamichael
removed
the
Passed manual tests
github-actions
Bot
added
the
Language: Javascript
kongtiaowang
changed the title
lapadulamichael
added
the
Passed manual tests
driusan
reviewed
Jun 30, 2026
Collaborator
|
@kongtiaowang I don't understand why the "Files" became "Videos" in this PR. Doesn't the document repository mostly consist of non-video files? Some of the references to "video" in the diff seem to already exist, but wouldn't it make more sense to change those to "File" instead of changing the "File" references to "Video"? |
**Situation:** In the LORIS `user_accounts` module (`edit_user` interface), clicking the "Reject User" button triggers an immediate AJAX call to reject the account. There is no confirmation dialog, making it extremely easy for an administrator to accidentally reject a user with a misclick. **Task:** My objective was to introduce a confirmation step before executing the rejection AJAX call, ensuring a better and safer user experience. The implementation needed to adhere strictly to modern LORIS framework standards, specifically utilizing the SweetAlert2 library. **Action:** - **Refactored Legacy Code:** Converted the plain jQuery script `modules/user_accounts/js/rejectUser.js` into a modern proper source file at `modules/user_accounts/jsx/rejectUser.js`. - **Integrated SweetAlert2:** Used modern Webpack imports (`import swal from 'sweetalert2';`) to implement a `swal.fire()` confirmation modal with a 'warning' type, standardizing the UI with other LORIS modules. - **Updated Webpack Entry Point:** Registered the new `rejectUser` file in `webpack.config.ts` under the `user_accounts` entry. - **Compiled Bundle:** Built the new asset via `npm run compile`, resulting in a self-contained Webpack JS bundle that replaces the old jQuery file. **Result:** Administrators can now see SweetAlert2 warning dialog when attempting to reject a user. The AJAX call is correctly blocked until the user explicitly clicks "Yes, reject user!", completely preventing accidental rejections and fixes aces#10474. <img width="1706" height="972" alt="image" src="https://github.com/user-attachments/assets/686cbb68-072d-4d50-80d7-f7e91a9e7e51" />
…s#10685) ## Brief summary of changes The dataquery TestPlan specifies that queries should only be able to be pinned by users with "Data Query Tool: Admin dataquery queries" permission. - [x] Have you updated related documentation? #### Testing instructions (if applicable) 1. Verify the TestPlan #### Link(s) to related issue(s) * Resolves [10602](aces#10602). Co-authored-by: Michael Lapadula <michael.lapadula@mcin.ca>
## Brief summary of changes No notifications were being sent out because the "Active_to" condition in the query for users to be notified had the opposite logic than it should (it was checking users who have already had their access expired instead of users who are still active). - [ ] Have you updated related documentation? #### Testing instructions (if applicable) 1. Create a user and grant the user each permission from the my_preferences page. Make sure the user is active and does not have an active_to date set 2. Test each operation that sends notifications to make sure the notifications are properly sent 3. Edit the user to have an active_to date set before now 4. Make sure the notifications are not sent 5. Edit the user to have an active_to date set after now 6. Make sure the notifications are sent 7. Remove all of the notification settings from my_preferences page 8. Make sure that the notifications are not sent #### Link(s) to related issue(s) * Resolves aces#10588
Related to aces#10563 Fix 'Array' in the subject line. To test: Try resetting the password from the login page and check the notification email subject is `Lost Password - [study name]`. --------- Co-authored-by: root <root@cbrain.mcgill.ca>
github-actions
Bot
added
Module: statistics
Collaborator
|
@kongtiaowang It looks like this needs to be rebased? There's a bunch of unrelated changes in the diff now. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
document repo can't edit a file.
#10593
document repo can't detele a file.
#10592
after run
"target=document_repository npm run compile" to test